GitBox
2018-12-11 05:30:32 UTC
jsoref commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error
URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446077698
I've created a distinct PR for the newline changes. If you merge it first, I'm happy to deal w/ the merge conflicts.
However, it should be clear from the PR that it's *much* larger than the tiny incremental change I'm trying to make here and is totally inappropriate to mix with this PR.
Personally, having worked on larger projects, the change for #48 should be given significant review and consideration before being accepted, it might not be the right behavior, it might break things/expectations, it isn't a trivial change. Diffstat also reports it exceeds the trivial CLA requirements.
This PR otoh is a much smaller change which can be reviewed and should be dealt w/ on its own.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
***@infra.apache.org
With regards,
Apache Git Services
URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446077698
I've created a distinct PR for the newline changes. If you merge it first, I'm happy to deal w/ the merge conflicts.
However, it should be clear from the PR that it's *much* larger than the tiny incremental change I'm trying to make here and is totally inappropriate to mix with this PR.
Personally, having worked on larger projects, the change for #48 should be given significant review and consideration before being accepted, it might not be the right behavior, it might break things/expectations, it isn't a trivial change. Diffstat also reports it exceeds the trivial CLA requirements.
This PR otoh is a much smaller change which can be reviewed and should be dealt w/ on its own.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
***@infra.apache.org
With regards,
Apache Git Services