[GitHub] eolivelli commented on a change in pull request #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()

GitBox

2018-12-09 16:48:09 UTC

eolivelli commented on a change in pull request #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#discussion_r240044205

##########
File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
##########
@@ -84,4 +87,22 @@ public void testVersionlessManagedDependency()
// this is expected
}
}
+
+ public void testResolveDependencies() throws Exception {
+ File pomFile = new File( "src/test/resources/projects/basic-resolveDependencies.xml" );
+ MavenSession mavenSession = createMavenSession( null );
+ ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
+ configuration.setRepositorySession( mavenSession.getRepositorySession() );
+ configuration.setResolveDependencies(true);

Review comment:
Can we add a test in which this is false and assert that resolution actually does not happen ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org

With regards,
Apache Git Services