GitBox
2018-12-09 18:36:42 UTC
Tibor17 edited a comment on issue #206: SUREFIRE-1610: Add skipUTs flag to SurefirePlugin
URL: https://github.com/apache/maven-surefire/pull/206#issuecomment-445560406
This is not ideal approach to add one more parameter.
I guess you have a problem with the system property used by both plugins the same and you cannot segregate them. Is it so?
We had an ambition to add prefixes `surefire` and `failsafe` in the old system properties which do not have them. At the same time we should remove `skipTests` from `maven-failsafe-plugin` because this have been associated with unit tests for long and thus `maven-surefire-plugin`. On the other side the `maven-failsafe-plugin` has a better property to use `skipITs`. Since the `skip***` system properties are so famous and have been used everywhere, we should not add prefixes for those; otherwise we broke all the world. We can make it with other system properties. We want to remove deprecated config paramaters in the last milestone of 3.0.0. One more reason to do these unpopular changes is the fact that system properties without prefixes interfere with other plugins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
***@infra.apache.org
With regards,
Apache Git Services
URL: https://github.com/apache/maven-surefire/pull/206#issuecomment-445560406
This is not ideal approach to add one more parameter.
I guess you have a problem with the system property used by both plugins the same and you cannot segregate them. Is it so?
We had an ambition to add prefixes `surefire` and `failsafe` in the old system properties which do not have them. At the same time we should remove `skipTests` from `maven-failsafe-plugin` because this have been associated with unit tests for long and thus `maven-surefire-plugin`. On the other side the `maven-failsafe-plugin` has a better property to use `skipITs`. Since the `skip***` system properties are so famous and have been used everywhere, we should not add prefixes for those; otherwise we broke all the world. We can make it with other system properties. We want to remove deprecated config paramaters in the last milestone of 3.0.0. One more reason to do these unpopular changes is the fact that system properties without prefixes interfere with other plugins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
***@infra.apache.org
With regards,
Apache Git Services