[GitHub] jsoref commented on a change in pull request #47: Improve output

[GitBox]

jsoref commented on a change in pull request #47: Improve output
URL: https://github.com/apache/maven-enforcer/pull/47#discussion_r240389410



##########
File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequirePluginVersions.java
##########
@@ -278,8 +278,9 @@ public void execute( EnforcerRuleHelper helper )
{
newMsg.append( "SNAPSHOT " );
}
- newMsg.append( "are not allowed )\n" );
+ newMsg.append( "are not allowed)" );
}
+ newMsg.append( "\n" );
for ( Plugin plugin : failures )

Review comment:
You consistently use `\n` in this file. If you want to switch, that should be a distinct PR. It would fail the requirements for "tiny PRs" that don't need CLAs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services

[GitBox]

jsoref commented on a change in pull request #47: Improve output
URL: https://github.com/apache/maven-enforcer/pull/47#discussion_r240391703



##########
File path: enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequirePluginVersions.java
##########
@@ -278,8 +278,9 @@ public void execute( EnforcerRuleHelper helper )
{
newMsg.append( "SNAPSHOT " );
}
- newMsg.append( "are not allowed )\n" );
+ newMsg.append( "are not allowed)" );
}
+ newMsg.append( "\n" );
for ( Plugin plugin : failures )

Review comment:
@Tibor17: I'm matching the existing style. Such a change is beyond the scope of this PR, you really shouldn't ask me to do this.
https://github.com/apache/maven-enforcer/blob/d7d33f271865408a8c4207fb591e755ca5876bf9/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequirePluginVersions.java#L283
https://github.com/apache/maven-enforcer/blob/d7d33f271865408a8c4207fb591e755ca5876bf9/enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/RequirePluginVersions.java#L312

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
***@infra.apache.org


With regards,
Apache Git Services