GitBox
2018-12-11 06:09:53 UTC
khmarbaise commented on issue #47: [MENFORCER-323] - Improve output of "Some plugins are missing valid versions" error
URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446084374
@jsoref Creating a separate PR for the newline change is the right way to keep the change short and focused on a particular thing...and it's good that you realized that `\n` has been used on the files instead of `System.lineseparator`
Furthermore it would be a good idea to shorten the commit message and clean up the text. A detailed explanation can be done in the JIRA ticket...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
***@infra.apache.org
With regards,
Apache Git Services
URL: https://github.com/apache/maven-enforcer/pull/47#issuecomment-446084374
@jsoref Creating a separate PR for the newline change is the right way to keep the change short and focused on a particular thing...and it's good that you realized that `\n` has been used on the files instead of `System.lineseparator`
Furthermore it would be a good idea to shorten the commit message and clean up the text. A detailed explanation can be done in the JIRA ticket...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
***@infra.apache.org
With regards,
Apache Git Services