[jira] [Created] (MNG-6529) ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()

[Mickael Istria (JIRA)]

Mickael Istria created MNG-6529:
-----------------------------------

Summary: ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria


I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700541#comment-16700541 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

mickaelistria opened a new pull request #193: MNG-6529 - JUnit Test showcasing the bug
URL: https://github.com/apache/maven/pull/193


This adds a (failing) unit test showcasing that
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest)
doesn't honor ProjectBuildingRequest.isResolveDependencies()

Following this checklist to help us incorporate your
contribution quickly and easily:

- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.

If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.

- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)

- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

[core-its]: https://maven.apache.org/core-its/core-it-suite/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Priority: Critical
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Mickael Istria (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700542#comment-16700542 ]

Mickael Istria commented on MNG-6529:
-------------------------------------

https://github.com/apache/maven/pull/193 showcases the bug in a JUnit Test

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Priority: Critical
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Mickael Istria (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701127#comment-16701127 ]

Mickael Istria commented on MNG-6529:
-------------------------------------

Pull request https://github.com/apache/maven/pull/193 now contains something that looks like a fix.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Priority: Critical
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701259#comment-16701259 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

slachiewicz commented on issue #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#issuecomment-442283024


Build ok https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6529/

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Priority: Critical
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702965#comment-16702965 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

mickaelistria commented on issue #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#issuecomment-442778532


@slachiewicz Is there anything else I should do to influence this to get in 3.6.1 (and even a 3.5.4 if possible)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Priority: Critical
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714017#comment-16714017 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

eolivelli commented on a change in pull request #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#discussion_r240044205



##########
File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
##########
@@ -84,4 +87,22 @@ public void testVersionlessManagedDependency()
// this is expected
}
}
+
+ public void testResolveDependencies() throws Exception {
+ File pomFile = new File( "src/test/resources/projects/basic-resolveDependencies.xml" );
+ MavenSession mavenSession = createMavenSession( null );
+ ProjectBuildingRequest configuration = new DefaultProjectBuildingRequest();
+ configuration.setRepositorySession( mavenSession.getRepositorySession() );
+ configuration.setResolveDependencies(true);

Review comment:
Can we add a test in which this is false and assert that resolution actually does not happen ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714018#comment-16714018 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

eolivelli commented on a change in pull request #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#discussion_r240044168



##########
File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
##########
@@ -30,7 +32,8 @@
public class ProjectBuilderTest
extends AbstractCoreMavenComponentTestCase
{
- protected String getProjectsDirectory()
+ @Override
+ protected String getProjectsDirectory()

Review comment:
Nit: remove spaces

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Hervé Boutemy (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hervé Boutemy updated MNG-6529:
-------------------------------
Description:
I'm willing to update Eclipse m2e to take advantage of the {{ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)}} to avoid duplication of MavenProject in the IDE caused by {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.

It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].

However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a valid list of {{MavenProject.getArtifacts()}}.

was:
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to update Eclipse m2e to take advantage of the {{ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)}} to avoid duplication of MavenProject in the IDE caused by {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a valid list of {{MavenProject.getArtifacts()}}.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Robert Scholte (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte reassigned MNG-6529:
-----------------------------------

Assignee: Robert Scholte

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[Robert Scholte (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte updated MNG-6529:
--------------------------------
Fix Version/s: 3.6.1

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to upfate Eclipse m2e to take advantage of the `ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)` in Eclipse m2e to avoid duplication of MavenProject in the IDE in place of `ProjectBuilder.build(File singleFile, ProjectBuildingRequest)`. It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the `ProjectBuildRequest.isResolveDependencies()` flag and never returns a valid list of `MavenProject.getArtifacts()`.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714023#comment-16714023 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

mickaelistria commented on issue #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#issuecomment-445554138


Do you prefer an extra commit or should I squash them all in a single one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to update Eclipse m2e to take advantage of the {{ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)}} to avoid duplication of MavenProject in the IDE caused by {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a valid list of {{MavenProject.getArtifacts()}}.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714024#comment-16714024 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

rfscholte commented on issue #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#issuecomment-445554821


squash please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to update Eclipse m2e to take advantage of the {{ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)}} to avoid duplication of MavenProject in the IDE caused by {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a valid list of {{MavenProject.getArtifacts()}}.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714028#comment-16714028 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

hboutemy commented on issue #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#issuecomment-445555063


notice I updated the code in the branch
and I liked the 2 commits: one for failing test then the fix...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to update Eclipse m2e to take advantage of the {{ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)}} to avoid duplication of MavenProject in the IDE caused by {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a valid list of {{MavenProject.getArtifacts()}}.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[ASF GitHub Bot (JIRA)]

[ https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16714046#comment-16714046 ]

ASF GitHub Bot commented on MNG-6529:
-------------------------------------

mickaelistria commented on issue #193: MNG-6529 - ProjectBuild.build(projectsList, ...) ignores request.isResolveDependency()
URL: https://github.com/apache/maven/pull/193#issuecomment-445558505


Squashed, whitespace issue fixed, extra test added for `request.isResolveDependency() == false`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.

Post by Mickael Istria (JIRA)
ProjectBuilder.build(List<File> projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
---------------------------------------------------------------------------------------------------------------------------------------
Key: MNG-6529
URL: https://issues.apache.org/jira/browse/MNG-6529
Project: Maven
Issue Type: Bug
Components: core
Affects Versions: 3.5.3
Reporter: Mickael Istria
Assignee: Robert Scholte
Priority: Critical
Fix For: 3.6.1
I'm willing to update Eclipse m2e to take advantage of the {{ProjectBuilder.build(List<File> project, boolean, ProjectBuildingRequest)}} to avoid duplication of MavenProject in the IDE caused by {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
It's already measured to have drastically good impact on the IDE, as explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
However, using this cause regressions because the multi-projects entry-point method seems to totally ignore the {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a valid list of {{MavenProject.getArtifacts()}}.

--
This message was sent by Atlassian JIRA
(v7.6.3#76005)